Skip to content

Make file filter show the extension, instead of cryptic stuff #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 17, 2024
Merged

Make file filter show the extension, instead of cryptic stuff #82

merged 1 commit into from
Jul 17, 2024

Conversation

stefanhahmann
Copy link
Contributor

@stefanhahmann stefanhahmann commented May 28, 2024 •
edited
Loading

@stefanhahmann stefanhahmann force-pushed the add_file_filter_to_string branch from 7e9109d to 114db77 Compare May 28, 2024 21:36
@stefanhahmann
Make file filter show the extension, instead of cryptic stuff
205cdc4 
* Override FileFilter toString() method in SwingFileWidget so that it shows the extension(s) that are filtered by the file choose dialog instead of the standard toString() of the
* Related to
  * bigdataviewer/bigdataviewer-playground#110
  * https://forum.image.sc/t/scijava-command-file-extensions/29869/2
@stefanhahmann stefanhahmann force-pushed the add_file_filter_to_string branch from 114db77 to 205cdc4 Compare May 28, 2024 21:48
@stefanhahmann stefanhahmann marked this pull request as ready for review May 28, 2024 21:49
@stefanhahmann
Copy link
Contributor Author

@ctrueden may I ask you to have a look at this PR at some time?

@stefanhahmann stefanhahmann mentioned this pull request Jun 4, 2024
Closed
19 tasks
@stefanhahmann
Copy link
Contributor Author

@ctrueden just a reminder about this PR. I would like to use its functionality in some Mastodon extension.

@ctrueden ctrueden merged commit 5d97166 into scijava:master Jul 17, 2024
@ctrueden
Copy link
Member

@stefanhahmann Awesome, thank you very much, and sorry for the delay in review. Was in paper/grant mode, then vacation, until last week. I merged it.

I was going to cut a new scijava-ui-swing release, but unfortunately, SwingObjectWidgetTest.testObjectsCommand now fails on my local Linux machine. I'm investigating.

@ctrueden
Copy link
Member

The bug was due to an issue with scijava-common, solved by upgrading to the latest version. The scijava-ui-swing 1.0.2 release now contains this fix.

@stefanhahmann
Copy link
Contributor Author

The bug was due to an issue with scijava-common, solved by upgrading to the latest version. The scijava-ui-swing 1.0.2 release now contains this fix.

Awesome. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@stefanhahmann @ctrueden